TI-Basic Optimization

[spandiv]

[theraven17]

How about another classic to just keep this going? :p

Bomberman - http://www.ticalc.org/archives/files/fileinfo/350/35050.html
4893 KB

[JoostinOnline]

Would you like to specify what the goes in place of the smilies?

[DarkerLine]

Smilies fix0red.

[alexrudd]

The game isn't very flattering to Joe if you translate the slang from German. I would suggest removing it.

[IAmACalculator]

My gosh man, haven't you ever heard of a [­codebox]?

[spandiv]

[Weregoose]

I'd rather see it in a codebox so that I don't have to scroll a mile to reach nonadjacent posts; you can usually Ctrl+click on its contents and then paste it into Notepad, Wordpad, or what-else-have-you.

[spandiv]

[Super Speler]

The *unspoken* standard has always been (as far as I've seen) codebox for long pieces of code and goose tags for short.

[CyJackX]

This is a prime factoring program that I started two days ago. I made one, looked on this site, and found that Weregoose had already made a very quick one, so I did use some of his quicker tactics. However, I wanted to make a program that would:
1. Use whatever prime numbers it already knows first(LMasterPrimes)
2. If none of the primes in its masterlist are known, then to use brute force (go up by 1 each time)
3. Once it's finished, add the Primes list to its MasterPrime list, basically "learning" prime numbers to first test for in the future. (This is the last 5 lines of the code)

My computer is in chinese, so when I open the .8xp in TI-Graph Link, many of the symbols show up as crazy chinese words, so I had to go through and edit some things. If you know how to solve this problem, help would be appreciated. My computer can read those symbols on these forums, but they can't seem to comprehend them from the .8xp file.

If this code is confusing, I will go through it.

0-5 : Formality, number prompt and making sure it is an integer above 2
6: Deleting the previous run's answers
7: Setting the MasterPrime element to the first one
8: Putting 2 as the very first prime in the Master Prime list. This creates the list if this is the first time running it.
9: Storing the size of the MasterPrime list to a variable because it is referenced many times
10: Putting 2 as the first number of the "Brute Force"
11: Repeat the below process until X has been divided by all its factors, making it 1
12: This continually changes the Test number until X is evenly divided by it.
13-19: This is essentially the part that I have been wracking my brains over how to best code.
13: If there are still Masterprime numbers left, move up 1
14: The Prime number from the MasterPrime list at position Z
15: If that Prime is bigger than the squareroot of X or It has reached the end of the masterprime list,
16: Use T
17: If T is bigger than the squareroot of X,
18: Then store X to ans because it must be prime.
20: Whatever was eventually stored to ans, store it to the Prime List for the initial number
21: Then divide the current X by the ans to get a smaller X
22-24: Use T as ans if there aren't any Masterprimes left


Code:

0:Input "Number? ",X
1:If fPart(X)+(X<=1
2:Then
3:Disp "    Invalid!
4:Stop
5:End
6:0-->dim(LPRIMES
7:1-->Z
8:2-->LMasterPrimes(1
9:dim(LMasterPrimes-->Y
10:2-->T
11:Repeat X=1
12:While fPart(X/Ans
13:Z+(Z<Y-->Z
14:LMasterPrimes(Ans
15:If Ans>sqrt(X) or Z>=Y
16:T+1-->T
17:If Ans>sqrt(X
18:X
19:End
20:Ans-->LPrimes(1+dim(LPrimes
21:X/Ans-->X
22:LMasterPrimes(Z
23:If Ans>sqrt(X) or Z>=Y
24:T
25:End
26:For(X,1,dim(LMasterPrimes
27:If not(max(LMasterPrimes=LPrimes(X
28:LPrimes(X-->LMasterprimes(1+dim(LMasterprimes
29:End
30:SortA(LMasterprimes
31:LPrime

I've tried many different things for the code within the While( function, but this is the best i've gotten.

[Weregoose]

sqrt(X or Z≥Y? Uh oh. That's performing a test on whether one of X or Z≥Y is nonzero, so all this ends up doing is taking the square root of 0 or 1. I'm sure this is not what you meant!

[EDIT]

I've fixed this for you, so I will now begin looking at the code.

Let me also clarify that LPrimes can be taken as LP and the other list LMP, correct?

[EDIT×2]

Also, is max(LMasterPrimes=… supposed to be max(LMasterPrimes)=…?

[CyJackX]

[johnbasedow]

These are part of a program I found. Not my code, but I'd still like it optimized.

DelVar L1Prompt A,L
1->C
For(D,1,sqrt(A
If not(fPart(A/D
Then
D->L1(C
C+1->C
End
End

C-1->F

While F>0
L1(F)->G
F-1->F
A/G^2->K
If not(fPart(K
Then
blah, blah, blah... unimportant output stuff
End
End

[CyJackX]

[JoostinOnline]

Yes, I was wondering which variables need to be preserved as well. You really can't optimize somthing unless you know the point of the program.

[CyJackX]

With my prime program, I did this for the While section and managed to make it a little faster:


:1-->D


:While DfPart(X/Ans
:IS>(Z,Y
:LMasterPrimes(Z
:If Ans^2>X or Z>=Y
:Delvar D
:End
:While not(D)fPart(X/Ans
:T+1-->T
:If Ans^2>X
:X
:End

I wasn't sure if splitting it up into two seperate While(functions was quicker, but it seems to be.

[johnbasedow]

The only variables that need to be preserved are A and L

[CyJackX]

[CyJackX]

Bump?