I haven't fully verified the output of this yet, nor have I removed all my debug couts (i have them turned off, though), but this appears to be delivering good puzzles...
Unfortunately the formatting is a bit mashed, but it should still be readable
Code:
I also need to go over it and clean it up a bit, removing unneeded variables and such, but I'll do that after the output is verified
EDIT:
couldn't this:
Code:
Be replaced by 2 switch - case statement (or can you not do multiple conditions/checks other than ==?) ?
I have gone through and taken out all global variables.
Oh yeah, do you mean 4 arguments? because you need the random number too
A switch statement COULD be used, but it would be a bit longer, as you would have to list every case such as
Code:
I think the if-else statements are cleaner
The random number is set to grid[x][y] before check() is called, and therefore doesn't need to be passed to check(). This allows check() to be more generic function that can be used later on down the line.
EDIT2: Fixed a slight bug in the program that would have been an issue should the main do-while loop ever repeat, which shouldn't be able to happen anyway
Unfortunately the formatting is a bit mashed, but it should still be readable
Code:
/*******************
/A Rewritten Sudoku generator
/Based off of sudoku by Harq
/
/Author: Kllrnohj
/Version 1.0
/Released under the GNU GPL
/*******************/
//Includes - Prefer C++ versions
#include <iostream>
#include <cstdlib>
#include <ctime>
//Defines
#define surand() ((rand() % 9) + 1)
#define T_MAX_TRIES 50
#define DEBUG false
#define DEBUG_2 false
//Functions
bool check(int x, int y, int grid[9][9]);
void fill(int grid[9][9]);
bool verify(int grid[9][9]);
void fill_x(int x, int grid[9][9]);
void disp(int grid[9][9]);
int main(int argc, char *argv[]) {
using namespace std;
int reps, y_reps, total_retries = 0;
cout << "Generating puzzle...";
//Initialize the grid array
//Could also use a char array to reduce memory usage
int grid[9][9];
//Initialize the random number generator
srand(time(0));
do {
//Fill grid with 0s
fill(grid);
for (int x = 0; x < 9; x++) {
y_reps = 0;
for (int y = 0; y < 9; y++) {
reps = 0;
do {
grid[x][y] = surand();
reps++;
} while ((!check(x, y, grid)) and (reps < 50));
if (reps == 50) {
//Failed 25 times in a row
//Restart the previous column
if (DEBUG_2) {
disp(grid);
}
y = -1;
fill_x(x, grid);
y_reps++;
if (y_reps == 100) {
x--;
y_reps = 0;
fill_x(x, grid);
total_retries++;
}
if (total_retries == T_MAX_TRIES) {
cout << "ERROR!\n"
<< "Failed to create "
<< "puzzle. Reached T_MAX_"
<< "TRIES limit.\n";
disp(grid);
exit(1);
}
}
}
if (DEBUG_2) {
disp(grid);
}
}
} while (!verify(grid)); //This is redundant and could be removed
//Left in for demonstrative purposes
cout << "Success!\n";
//Display the completed grid
//Has fancier output than disp()
for (int x = 0; x < 9; x++) {
cout << "\n\t";
for (int y = 0; y < 9; y++) {
cout << grid[x][y] << " ";
if ((y == 2) or (y == 5)) {
cout << "| ";
}
}
if ((x == 2) or (x == 5)) {
cout << "\n\t---------------------";
}
}
cout << "\n\n";
return 0;
}
//Function definitions
void disp(int grid[9][9]) {
using namespace std;
for (int d_x = 0; d_x < 9; d_x++) {
cout << "\n\t";
for (int d_y = 0; d_y < 9; d_y++) {
cout << grid[d_x][d_y] << " ";
}
}
cout << endl;
}
void fill_x(int x, int grid[9][9]) {
for (int i = 0; i < 9; i++) {
grid[x][i] = 0;
}
}
bool verify(int grid[9][9]) {
for (int x = 0; x < 9; x++) {
for (int y = 0; y < 9; y++) {
if (!check(x, y, grid)) {
//return false;
}
}
}
return true;
}
void fill(int grid[9][9]) {
for (int x = 0; x < 9; x++) {
for (int y = 0; y < 9; y++) {
grid[x][y] = 0;
}
}
}
bool check(int x, int y, int grid[9][9]) {
int s_x, s_y;
if (DEBUG) {
std::cout << "Check( " << x << ", " << y << ", "
<< grid[x][y] << ")\n";
}
//Horiz check
for (int i = 0; i < 9; i++) {
if (DEBUG) {
std::cout << " " << grid[i][y]
<< " == " << grid[x][y] << std::endl;
}
if ((grid[i][y] == grid[x][y]) and (i != x)) {
return false;
}
}
if (DEBUG) {
std::cout << std::endl;
}
//Vert check
for (int i = 0; i < 9; i++) {
if (DEBUG) {
std::cout << " " << grid[x][i]
<< " == " << grid[x][y] << std::endl;
}
if ((grid[x][i] == grid[x][y]) and (i != y)) {
return false;
}
}
if (DEBUG) {
std::cout << std::endl;
}
//Square check
//Set square X offset
if ((x >= 0) and (x < 3)) {
s_x = 0;
} else if ((x >= 3) and (x < 6)) {
s_x = 3;
} else {
s_x = 6;
}
//Set square Y offset
if ((y >= 0) and (y < 3)) {
s_y = 0;
} else if ((y >= 3) and (y < 6)) {
s_y = 3;
} else {
s_y = 6;
}
//Check the square
for (int i_x = 0; i_x < 3; i_x++) {
for (int i_y = 0; i_y < 3; i_y++) {
if (DEBUG) {
std::cout << " " << grid[i_x + s_x][i_y + s_y]
<< " == " << grid[x][y] << std::endl;
}
if ((grid[i_x + s_x][i_y + s_y] == grid[x][y]) and
(i_x + s_x != x) and (i_y + s_y != y)) {
return false;
}
}
}
return true;
}
I also need to go over it and clean it up a bit, removing unneeded variables and such, but I'll do that after the output is verified
EDIT:
Quote:
couldn't this:
Code:
//Square check
//Set square X offset
if ((x >= 0) and (x < 3)) {
s_x = 0;
} else if ((x >= 3) and (x < 6)) {
s_x = 3;
} else {
s_x = 6;
}
//Set square Y offset
if ((y >= 0) and (y < 3)) {
s_y = 0;
} else if ((y >= 3) and (y < 6)) {
s_y = 3;
} else {
s_y = 6;
} Be replaced by 2 switch - case statement (or can you not do multiple conditions/checks other than ==?) ?
I have gone through and taken out all global variables.
Oh yeah, do you mean 4 arguments? because you need the random number too
A switch statement COULD be used, but it would be a bit longer, as you would have to list every case such as
Code:
case 0:
case 1:
case 2:
s_x = 0;
break;
I think the if-else statements are cleaner
The random number is set to grid[x][y] before check() is called, and therefore doesn't need to be passed to check(). This allows check() to be more generic function that can be used later on down the line.
EDIT2: Fixed a slight bug in the program that would have been an issue should the main do-while loop ever repeat, which shouldn't be able to happen anyway
, that was one of my purposes, to reinforce all that i had learned.