Please help with Bdisp_AreaClr()
» > >
»
» View previous topic :: View next topic  
I clear screen with Bdisp_AreaClr() but it does not work quite right. It looks like old screen content over-write the cleared area. Why's that?

Some one please help. Thanks a lot!!

Relevant code as below. Notice I called clear() function both before & whithin the GetKey() loop (indirectly by on_key() function).


Code:

int main() {

    text_pos.line = 0;
    text_pos.x = 0;

    for (int i = 0; i < MAX_LINES; ++i) {
        text_buf[ LINE_BUF_SIZE * i] = 0;
    }

    [color=red]clear();[/color]

    int key;
    while (1) {
        GetKey(&key);
        if ((key = accept(key))) {
            [color=blue]on_key(key);[/color]
        }
    }

    return 0;
}

static void clear() {
    struct display_fill area = { //
            .x1 = 6, //
            .y1 = 24 , //
            .x2 = 100 , //
            .y2 =  100 , //
            .mode = 1 , //
    };
    Bdisp_AreaClr(&area, 0x02, COLOR_LIGHTGRAY);
}
子非魚 安知魚之樂
I paste the complete source code here . Basically the program prints key input, with line-wrapping and at most 3 lines of text are printed.


Code:


#include <stdlib.h>
#include <string.h>
#include <fxcg/display.h>
#include <fxcg/keyboard.h>

#define MAX_LINES               3
#define LINE_BUF_SIZE           64
#define LINE_HEIGHT             18

static char text_buf[ MAX_LINES * LINE_BUF_SIZE];

static struct {
    int line;
    int x;
} text_pos;

static void clear() ;
static int accept(int key);
static void on_key(int key);
static void append_line(char *str, char c);

int main() {

    text_pos.line = 0;
    text_pos.x = 0;

    for (int i = 0; i < MAX_LINES; ++i) {
        text_buf[ LINE_BUF_SIZE * i] = 0;
    }

    clear();

    int key;
    while (1) {
        GetKey(&key);
        if ((key = accept(key))) {
            on_key(key);
        }
    }

    return 0;
}

static void clear() {
    struct display_fill area = { //
            .x1 = 6, //
            .y1 = 24 , //
            .x2 = 100 , //
            .y2 =  100 , //
            .mode = 1 , //
    };
    Bdisp_AreaClr(&area, 0x02, COLOR_LIGHTGRAY);
}

static int accept(int key) {
    if ('a' <= key && key <= 'z') {
        return key;
    }
    if ('A' <= key && key <= 'Z') {
        return key;
    }
    if ('0' <= key && key <= '9') {
        return key;
    }

    return 0;

}
static void on_key(int key) {

    int x = text_pos.x;
    int y = text_pos.line * LINE_HEIGHT;

    char buf[2] = { 0 };
    buf[0] = key;

    PrintMini(&x, &y, buf, 0, 0xFFFFFFFFU, 0, 0, COLOR_BLUE, COLOR_YELLOW, 0, 0);

     // Print to end
    if (x <= LCD_WIDTH_PX) {
        x = text_pos.x;
        y = text_pos.line * LINE_HEIGHT;
        PrintMini(&x, &y, buf, 0, 0xFFFFFFFFU, 0, 0, COLOR_BLUE, COLOR_YELLOW, 1, 0);
        text_pos.x = x;

        append_line(text_buf + LINE_BUF_SIZE * text_pos.line, key);

        return;
    }

    // Print to new line
    if (text_pos.line + 1 < MAX_LINES) {
        x = 0;
        y = (1 + text_pos.line) * LINE_HEIGHT;
        PrintMini(&x, &y, buf, 0, 0xFFFFFFFFU, 0, 0, COLOR_BLUE, COLOR_YELLOW, 1, 0);
        text_pos.line++;
        text_pos.x = x;

        append_line(text_buf + LINE_BUF_SIZE * text_pos.line, key);
        return;
    }

    // Scroll up by 1 line, then print to new line ----

    clear();

    for (int i = 0; i < MAX_LINES - 1; ++i) {
        char *line = text_buf + i * LINE_BUF_SIZE;
        memcpy(line, line + LINE_BUF_SIZE, LINE_BUF_SIZE);
        x = 0;
        y = i * LINE_HEIGHT;
        PrintMini(&x, &y, line, 0, 0xFFFFFFFFU, 0, 0, COLOR_BLUE, COLOR_YELLOW, 1, 0);
    }

    // Last line: empty
    *(text_buf + ( MAX_LINES - 1) * LINE_BUF_SIZE) = 0;

//    struct display_fill area ;
//    area.x1 =0 ;
//    area.y1 = LINE_HEIGHT * (MAX_LINES-1) ;
//    area.x2 = LCD_WIDTH_PX  ;
//    area.y2 =  area.y1 ;
//    area.mode = 1;
//    Bdisp_AreaClr( &area, 0x03, COLOR_WHITE) ;

    x = 0;
    y = (MAX_LINES - 1) * LINE_HEIGHT;
    PrintMini(&x, &y, buf, 0, 0xFFFFFFFFU, 0, 0, COLOR_BLUE, COLOR_YELLOW, 1, 0);
    text_pos.line = MAX_LINES - 1;
    text_pos.x = x;

    append_line(text_buf + LINE_BUF_SIZE * text_pos.line, key);
    return;
}

static void append_line(char *str, char c) {
    for (int i = 0; i < LINE_BUF_SIZE - 1; ++i) {
        if (0 == str[i]) {
            str[i] = c;
            str[i + 1] = 0;
            return;
        }
    } // for
}


子非魚 安知魚之樂
si wrote:
I clear screen with Bdisp_AreaClr() but it does not work quite right. It looks like old screen content over-write the cleared area. Why's that?

Some one please help. Thanks a lot!!

Relevant code as below. Notice I called clear() function both before & whithin the GetKey() loop (indirectly by on_key() function).


Code:

int main() {

    text_pos.line = 0;
    text_pos.x = 0;

    for (int i = 0; i < MAX_LINES; ++i) {
        text_buf[ LINE_BUF_SIZE * i] = 0;
    }

    [color=red]clear();[/color]

    int key;
    while (1) {
        GetKey(&key);
        if ((key = accept(key))) {
            [color=blue]on_key(key);[/color]
        }
    }

    return 0;
}

static void clear() {
    struct display_fill area = { //
            .x1 = 6, //
            .y1 = 24 , //
            .x2 = 100 , //
            .y2 =  100 , //
            .mode = 1 , //
    };
    Bdisp_AreaClr(&area, 0x02, COLOR_LIGHTGRAY);
}

See the wiki, target should be 1 or 0.
In this case, you probably want 0 as it is called before GetKey which will update the display.
dr-carlos wrote:

See the wiki, target should be 1 or 0.
In this case, you probably want 0 as it is called before GetKey which will update the display.


Hi dr-carlos, if I understand the wiki right, bit 0 set (to 1) selects VRAM while bit 1 selects DD. Therefore 0x02 selects DD. Bdisp_AreaClr() itself is not the real problem in my case. I observed a gray rectange area appeared then covered by white background in a blink of time
子非魚 安知魚之樂
si wrote:
dr-carlos wrote:

See the wiki, target should be 1 or 0.
In this case, you probably want 0 as it is called before GetKey which will update the display.


Hi dr-carlos, if I understand the wiki right, bit 0 set (to 1) selects VRAM while bit 1 selects DD. Therefore 0x02 selects DD. Bdisp_AreaClr() itself is not the real problem in my case. I observed a gray rectange area appeared then covered by white background in a blink of time

Yeah, I wasn't sure if this was the problem - but I thought I'd point it out anyway.
Someone else might know the cause.
You're performing the clear as a DD operation, but then immediately call GetKey(), which pushes Bdisp_PutDisp_DD() - resulting in the VRAM overriding the clear. Same after the on_key() call.

Here, you must either clear to VRAM and allow GetKey() to push the result to the display, or not use GetKey() for key input.
Lephe wrote:
You're performing the clear as a DD operation, but then immediately call GetKey(), which pushes Bdisp_PutDisp_DD() - resulting in the VRAM overriding the clear. Same after the on_key() call.

Here, you must either clear to VRAM and allow GetKey() to push the result to the display, or not use GetKey() for key input.


Lephe, I guess your theory about DD, VRAM and GetKey() is right. By calling Bdisp_AreaClr() with VRAM as target, now it does clear the specified rectangle area whereas the color is white instead of expected gray. Do I miss anything else?
子非魚 安知魚之樂
I disassembled modes 0/1 of the syscall to be sure (... I was a bit bored admittedly):

Code:
cg_3.60 @ 0x80000000> d %2b2

# r4: &area (struct { uint32_t x1 y1 x2 y2; uint8_t mode; })
#     for mode: 0=fill white, 1=fill color, 2=shade color, 4=invert
# r5: target (#1: VRAM, #2: DD, can be combined)
# r6: color
# stack> (y2) (?:u32) (?:u32) pr r14 r13 r12 r11 r10 r9 r8

<%2b2 Bdisp_AreaClr>
 # Save registers, r8=x2, r9=target, r12=x1
 80056d7c:  2f86   mov.l   r8, @-r15
 80056d7e:  2f96   mov.l   r9, @-r15
 80056d80:  2fa6   mov.l   r10, @-r15
 80056d82:  2fb6   mov.l   r11, @-r15
 80056d84:  2fc6   mov.l   r12, @-r15
 80056d86:  2fd6   mov.l   r13, @-r15
 80056d88:  2fe6   mov.l   r14, @-r15
 80056d8a:  4f22   sts.l   pr, @-r15
 80056d8c:  7ff4   add     #-12, r15
 80056d8e:  6c42   mov.l   @r4, r12
 80056d90:  6953   mov     r5, r9
 80056d92:  5242   mov.l   @(8,r4), r2

 # Swap r8/r12 (x1/x2) to that r8<r12
 80056d94:  3c27   cmp/gt  r2, r12
 80056d96:  8d02   bt.s    <0x80056d9e>
 80056d98:  6823   mov     r2, r8
 80056d9a:  68c3   mov     r12, r8
 80056d9c:  6c23   mov     r2, r12

 # Swap y1/y2 so that y1<y2, then r11=y1 and r1/@r15=y2
 80056d9e:  5141   mov.l   @(4,r4), r1
 80056da0:  5243   mov.l   @(12,r4), r2
 80056da2:  3127   cmp/gt  r2, r1
 80056da4:  8b02   bf      <0x80056dac>
 80056da6:  6b23   mov     r2, r11
 80056da8:  a003   bra     <0x80056db2>
 80056daa:  2f12   mov.l   r1, @r15
 80056dac:  6b13   mov     r1, r11
 80056dae:  6123   mov     r2, r1
 80056db0:  2f22   mov.l   r2, @r15

 # If x1 < 0, return (no clipping is performed)
 80056db2:  4811   cmp/pz  r8
 80056db4:  8901   bt      <0x80056dba>
 80056db6:  a08a   bra     <0x80056ece>
 80056db8:  0009   nop

 # If x2 >= 384, also give up
 80056dba:  e260   mov     #96, r2
 80056dbc:  4208   shll2   r2
 80056dbe:  3c23   cmp/ge  r2, r12
 80056dc0:  8b01   bf      <0x80056dc6>
 80056dc2:  a084   bra     <0x80056ece>
 80056dc4:  0009   nop

 # If y1 < 0, also give up
 80056dc6:  4b11   cmp/pz  r11
 80056dc8:  8901   bt      <0x80056dce>
 80056dca:  a080   bra     <0x80056ece>
 80056dcc:  0009   nop

 # If y2 >= 216, also give up
 80056dce:  e2d8   mov     #-40, r2
 80056dd0:  622c   extu.b  r2, r2
 80056dd2:  3123   cmp/ge  r2, r1
 80056dd4:  897b   bt      <0x80056ece>

 # If mode=1, set r10=color, else r10=0xffff (white)
 80056dd6:  e010   mov     #16, r0
 80056dd8:  024c   mov.b   @(r0,r4), r2
 80056dda:  622c   extu.b  r2, r2
 80056ddc:  6023   mov     r2, r0
 80056dde:  8801   cmp/eq  #1, r0
 80056de0:  8b01   bf      <0x80056de6>
 80056de2:  a002   bra     <0x80056dea>
 80056de4:  6a63   mov     r6, r10
 80056de6:  eaff   mov     #-1, r10
 80056de8:  6aad   extu.w  r10, r10

 # Switch on mode
 80056dea:  6023   mov     r2, r0
 80056dec:  8804   cmp/eq  #4, r0
 80056dee:  8903   bt      <0x80056df8>
 80056df0:  8802   cmp/eq  #2, r0
 80056df2:  892e   bt      <0x80056e52>
 80056df4:  a04f   bra     <0x80056e96>
 80056df6:  0009   nop

 #---
 # mode=4
 #---

 80056df8:  679c   extu.b  r9, r7
 80056dfa:  1f72   mov.l   r7, @(8,r15)
 80056dfc:  61f2   mov.l   @r15, r1
 80056dfe:  3b17   cmp/gt  r1, r11
 80056e00:  8965   bt      <0x80056ece>

 80056e02:  a022   bra     <0x80056e4a>
 80056e04:  6d83   mov     r8, r13

 80056e06:  6093   mov     r9, r0
 80056e08:  c902   and     #2, r0
 80056e0a:  6e03   mov     r0, r14
 80056e0c:  6093   mov     r9, r0
 80056e0e:  c801   tst     #1, r0
 80056e10:  890a   bt      <0x80056e28>
 80056e12:  d14f   mov.l   %266 Bdisp_GetPoint_VRAM_WB, r1
 80056e14:  65b3   mov     r11, r5
 80056e16:  410b   jsr     @r1
 80056e18:  64d3   mov     r13, r4
 80056e1a:  660d   extu.w  r0, r6
 80056e1c:  d74d   mov.l   %263 Bdisp_SetPoint_VRAM, r7
 80056e1e:  6a67   not     r6, r10
 80056e20:  65b3   mov     r11, r5
 80056e22:  64d3   mov     r13, r4
 80056e24:  470b   jsr     @r7
 80056e26:  66a3   mov     r10, r6

 80056e28:  2ee8   tst     r14, r14
 80056e2a:  890d   bt      <0x80056e48>
 80056e2c:  50f2   mov.l   @(8,r15), r0
 80056e2e:  8803   cmp/eq  #3, r0
 80056e30:  8905   bt      <0x80056e3e>
 80056e32:  da49   mov.l   %26e Bdisp_GetPoint_DD_WB, r10
 80056e34:  65b3   mov     r11, r5
 80056e36:  4a0b   jsr     @r10
 80056e38:  64d3   mov     r13, r4
 80056e3a:  6e0d   extu.w  r0, r14
 80056e3c:  6ae7   not     r14, r10
 80056e3e:  d247   mov.l   %26b Bdisp_SetPoint_DD, r2
 80056e40:  66a3   mov     r10, r6
 80056e42:  65b3   mov     r11, r5
 80056e44:  420b   jsr     @r2
 80056e46:  64d3   mov     r13, r4
 80056e48:  7d01   add     #1, r13

 80056e4a:  3dc7   cmp/gt  r12, r13
 80056e4c:  8bdb   bf      <0x80056e06>
 80056e4e:  afd5   bra     <0x80056dfc>
 80056e50:  7b01   add     #1, r11

 #---
 # mode=2
 #---

 80056e52:  666d   extu.w  r6, r6
 80056e54:  1f61   mov.l   r6, @(4,r15)
 80056e56:  61f2   mov.l   @r15, r1
 80056e58:  3b17   cmp/gt  r1, r11
 80056e5a:  8938   bt      <0x80056ece>
 80056e5c:  a017   bra     <0x80056e8e>
 80056e5e:  6d83   mov     r8, r13
 80056e60:  60d3   mov     r13, r0
 80056e62:  30bc   add     r11, r0
 80056e64:  c801   tst     #1, r0
 80056e66:  8b11   bf      <0x80056e8c>
 80056e68:  6093   mov     r9, r0
 80056e6a:  c902   and     #2, r0
 80056e6c:  6e03   mov     r0, r14
 80056e6e:  6093   mov     r9, r0
 80056e70:  c801   tst     #1, r0
 80056e72:  8904   bt      <0x80056e7e>
 80056e74:  d237   mov.l   %263 Bdisp_SetPoint_VRAM, r2
 80056e76:  65b3   mov     r11, r5
 80056e78:  56f1   mov.l   @(4,r15), r6
 80056e7a:  420b   jsr     @r2
 80056e7c:  64d3   mov     r13, r4
 80056e7e:  2ee8   tst     r14, r14
 80056e80:  8904   bt      <0x80056e8c>
 80056e82:  d236   mov.l   %26b Bdisp_SetPoint_DD, r2
 80056e84:  65b3   mov     r11, r5
 80056e86:  56f1   mov.l   @(4,r15), r6
 80056e88:  420b   jsr     @r2
 80056e8a:  64d3   mov     r13, r4
 80056e8c:  7d01   add     #1, r13
 80056e8e:  3dc7   cmp/gt  r12, r13
 80056e90:  8be6   bf      <0x80056e60>
 80056e92:  afe0   bra     <0x80056e56>
 80056e94:  7b01   add     #1, r11

 #---
 # mode=0 and mode=1
 #---

 # Outer loop: r11 initialized to y1, increases until y2
 # If r11>y2, return
 80056e96:  61f2   mov.l   @r15, r1
 80056e98:  3b17   cmp/gt  r1, r11
 80056e9a:  8918   bt      <0x80056ece>
 80056e9c:  a013   bra     <0x80056ec6>
 80056e9e:  6d83   mov     r8, r13

 # Inner loop: r13 initialized to x1, increases until x2
 # Save (target&2) in r14
 80056ea0:  6093   mov     r9, r0
 80056ea2:  c902   and     #2, r0
 80056ea4:  6e03   mov     r0, r14
 # If (target&1), set the current point in VRAM with the selected color
 80056ea6:  6093   mov     r9, r0
 80056ea8:  c801   tst     #1, r0
 80056eaa:  8904   bt      <0x80056eb6>
 80056eac:  d229   mov.l   %263 Bdisp_SetPoint_VRAM, r2
 80056eae:  66a3   mov     r10, r6
 80056eb0:  65b3   mov     r11, r5
 80056eb2:  420b   jsr     @r2
 80056eb4:  64d3   mov     r13, r4
 # If (target&2), set the same point on the DD
 80056eb6:  2ee8   tst     r14, r14
 80056eb8:  8904   bt      <0x80056ec4>
 80056eba:  d228   mov.l   %26b Bdisp_SetPoint_DD, r2
 80056ebc:  66a3   mov     r10, r6
 80056ebe:  65b3   mov     r11, r5
 80056ec0:  420b   jsr     @r2
 80056ec2:  64d3   mov     r13, r4
 # End of inner loop, x1++
 80056ec4:  7d01   add     #1, r13
 # While guard of inner loop, when r13 > x2 go back to outer loop with y1++
 80056ec6:  3dc7   cmp/gt  r12, r13
 80056ec8:  8bea   bf      <0x80056ea0>
 80056eca:  afe4   bra     <0x80056e96>
 80056ecc:  7b01   add     #1, r11

 # Epilogue
 80056ece:  7f0c   add     #12, r15
 80056ed0:  4f26   lds.l   @r15+, pr
 80056ed2:  6ef6   mov.l   @r15+, r14
 80056ed4:  6df6   mov.l   @r15+, r13
 80056ed6:  6cf6   mov.l   @r15+, r12
 80056ed8:  6bf6   mov.l   @r15+, r11
 80056eda:  6af6   mov.l   @r15+, r10
 80056edc:  69f6   mov.l   @r15+, r9
 80056ede:  000b   rts
 80056ee0:  68f6   mov.l   @r15+, r8

The color argument must be 16-bit since it's passed directly to Bdisp_SetPoint_VRAM(), so COLOR_LIGHTGRAY should work; apart from that the color is the same for both VRAM and DD.

Does it give you a white rectangle for every color? Did you make sure you're not overwriting the white afterwards?
Lephe wrote:
...
The color argument must be 16-bit since it's passed directly to Bdisp_SetPoint_VRAM(), so COLOR_LIGHTGRAY should work; apart from that the color is the same for both VRAM and DD.

Does it give you a white rectangle for every color? Did you make sure you're not overwriting the white afterwards?


Weird. Looks yes it clears white whatever color I specify. BUT when I plug USB in then press F1, the cleared area turned to gray (which is specified in Bdisp_AreaClr() call) befor it was covered by the USB connection screen.

I did nothing relating to graphics except call PrintMini() in the GetKey() loop.


Code:

Code:
//    clear();
    struct display_fill area = { //
            .x1 = 0, //
                    .y1 = 24 + (MAX_LINES - 1) * LINE_HEIGHT, //
                    .mode = 1, // Fill with color
            };
    area.x2 = area.x1 + LCD_WIDTH_PX - 1;
    area.y2 = area.y1 + LINE_HEIGHT -1;
    Bdisp_AreaClr(&area, 0x01 /* VRAM */, COLOR_DARKGRAY);
子非魚 安知魚之樂
This is really strange. Well, that syscall isn't worth much, so have you tried to inline it?

Code:
static void clear() {
    // Yes, that's shorter than the original code :)
    for(int y = 24; y <= 100; y++)
    for(int x = 6; x <= 100; x++)
        Bdisp_SetPoint_VRAM(x, y, COLOR_LIGHTGRAY);
}

Surely the API can't be that counter-intuitive, it should work at some point.
Well life is all about art of compromising, so I compromise. Change color to white and pretend that it is respected Wink
This code is my Hello World v2.0, as a proof of concept, to output some debug info in future projects. White is fine for that purpose. All colors matter after all.
Thank you so much for your help! @Lephe
子非魚 安知魚之樂
  
Register to Join the Conversation
Have your own thoughts to add to this or any other topic? Want to ask a question, offer a suggestion, share your own programs and projects, upload a file to the file archives, get help with calculator and computer programming, or simply chat with like-minded coders and tech and calculator enthusiasts via the site-wide AJAX SAX widget? Registration for a free Cemetech account only takes a minute.

» Go to Registration page
Please help with Bdisp_AreaClr()
»
» View previous topic :: View next topic  
Page 1 of 1
» All times are UTC - 5 Hours
 
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum

 

Advertisement