I have been working on my first big assembly program. But it appears I have made and error somewhere.


Code:



When ran the value for china's health is 65****, but when i remove



Code:


It works perfectly. What is the error here? Shouldn't it just set the value to 100?

I tried to make a variable by

Code:

and etc. But Tasm cant compile it.

So what have I done wrong here?

Welcome to Cemetech! A few recommendations:
1) TASM is outdated and has a number of issues. Have you considered Brass, SPASM-ng, or even emSPASM-ng in SourceCoder?
2) Since labels don't affect the size of the output ASM program, let them be longer and more descriptive! Why use ENEMYH when you can use Display_Enemy_Health:?
3) Convention and good coding practices put the data after all the code in the program, so EXIT shouldn't be hiding after your .dbs.

The problem with your program is that you're defining EH, UHH, etc as .db (one byte), but you're using them with a two-byte register, DE. If you want them to be two bytes, you need to reserve their space using .dw. An even better option would be to use AppBackupScreen, as you were starting to do. At the beginning of the program, even before the .org, you'd do something like:

Code:

Thank you very much for the help
1. I originally tried to as I only had a 64 bit computer but I could not get it to work (brass, spasm, and the source coder), so I went out and bought a 32 bit HP 6735b and a 32 bit copy of windows 7 ultimate (okay maybe not so much as bought as used i2p to get it) so I could use TASM.

2. AHH, okay I thought that it would, that is very good to know.

3. Again, thank you ill remember that.

Okay, I never though of the fact that the type of variable declaration and the type of register would affect it. That made it work. Sorry for the newbie error.

As for the .equ. I originally used that when I first began programming using mimas on calc but Tasm can't compile it :/. Ill have to look for a fix online.

Thank you very much, I appreciate the help.

Oh my goodness! You went out and bought a whole computer for this? Such dedication!
Unfortunately (or fortunately, depending on your outlook), you don't need a 32 bit copy of Windows to code in assembly. I use SpasmNG, which allows you to compile programs on a 64 bit computer (or 32 bit still). You can even compile for a 84+CE. You can download it here: https://github.com/alberthdev/spasm-ng/releases.

Well, I bought it for $15 and then $20 for a 120gb SSD so it was not much dedication.

Oh,well. I'll just install centOS on this computer and use it to host my BBS, as the current computer is even worse.

As well as the fact that no code can be run after $BFFF, so you have about 8.8kb of executable code (the program is run from $9D95) without hacks. Putting the data at the end of your program doesn't take up the space for executable code. For small programs, it's not an issue.

Also, penCol and penRow are consecutive bytes in memory (just like curRow and curCol, yeah, curRow comes before curCol but penCol comes before penRow, who knows why they decided to do it that way). So you can use a 16-bit register (preferable HL, since it's faster and smaller when loading to/from addresses). Also, beware that when you do 'ld (curCol),hl', you're loading L into (curCol) and H into (curCol+1). You can instead do something like:

Code:

which is equivalent to:

Code:

You can do the same trick with penCol (just remember that penCol comes before penRow in memory, it's the opposite of the big font, where curRow comes first). You can check the addresses of the equates in ti83plus.inc to verify.

There's also a bit we could do to make the menu much smaller and easier to make new menus, if you're interested we can give you some suggestions. For example, what about having a loop that reads through each menu item and displays it one at a time, before each text you would put the coordinates where you want to draw the text:

Code:
A little hint, _VPutS leaves hl pointing to the byte after the 0, so you can load mainMenu into HL, load the first value into penCol (you can use ldi, otherwise you'll have to load the value into a first then into penCol), load the second value into penRow, then run _VPutS. After that, hl will be pointing to the next menu entry. Repeat the loop until you've reached the end of your menu. You can either tell the routine how many menu items there are or you can put a special byte at the end (eg. $FF) which will tell the routine you've reached the end of the menu and should quit.