well i was just going to do:


Code:

first things first sorry about the double post.i just did it so it would get noticed.

but here is my real problem when i try to assemble this code it runs into an error and i was wondering if anyone can help. the error is unused data with loading 8 into b.


Code:

It's perfectly acceptable to double post if more than a day has passed. If you had just editted your post nobody would have noticed. Don't worry about it.

Lafferjm, TASM errors are there to help you fix the problem. Part of the error message will give you a specific line number where the error is. If your using a decent IDE (try Notepad++ or Crimson Editor if you're not), than it will have line numbers. Go to the appropriate line (sometimes it's a line or so off), and try to remedy it yourself. As it is, you've given me no line number so I don't have a clue where in the code this is, so I have a much worse chance than you of finding it.

I might be wrong, but I don't think you can do:
Code:
I'm pretty sure you can only directly access ram using hl or a. I'd say that's your problem, except it has nothing to do with b.

so do:
[code]
ld a,(chary)
ld l,a

Yes. Also, why did you do this?
Code:
It looks like you're trying to move the keypress from Op2 into A, but it's already in the accumulator! You don't need to do any of the bcalls there, hence why it wasn't working.

well those helped except now i just have to get ion to recognize it as a program

Are you sure that you have the header right and everything? Post the first 20 or so lines of your program.

Code:

Code:

thanks. it is always that one line that can mess up anything

Yup, the ret is key there.

well i now have a working sprite moving program. i will get to posting the code later on. now i just have to figure out how to stop it from going off screen.

That's easy - just check the x and y coordinates in the move routines.

alright. oh and here is the version without the stopping from going out of screen. is there anyway i can make it smaller.


Code:

1: Why do you have charx as sram and chary as sram+2. You're only storing 1 byte number to it, so you can make chary sram+1.

2: If you do that, you can use hl to more effectively index these coordinates and save a bit of space. For example this:

Code:

Becomes this:

Code:


3: You could make a display routine to save a few bytes. That way after you set up the coordinates after they press right left or whatever, just call display (which contains the code: ld b,8 / ld ix,sprite / call ionputsprite / call ionfastcopy / ret) instead of having those redundant lines.

4: Everytime you call erase, you call ionputsprite right after, so why not make that part of the erase routine and save a few bytes.

5: Change this:


Code:


Into this:


Code:


6: Get rid of that jr keypress at the end of the 'begin' routine. Just like in BASIC it's not necessary to jump to a lbl if it's the next line.

There are probably some more I missed, but this should get you thinking.

all right here is the new code. i think i did what you suggested. oh and that jr has to be there it is part of the ion header.


Code:

No, "Jr KeyPress" is the jr I meant. It's under the begin routine. The first Jr Keypress does not need to be their. Also, you didn't change the keypress routine as I had suggested (mine will save memory). Lastly, you decided against using hl to index I guess. It would save quite a bit of memory if you would use it, but I guess it might be too advanced for you at this stage.

Good job. I'd like to see what you do next.

Do you see why that will malfunction badly? Loading the contents of hl into l will modify hl, making 'a' completely invalid, and also making that inc (hl) do some fun randomization of your RAM. After ld hl,chary do ld b,(hl), then do ld l,b right before ld b,8.

Lol, I missed that. Nice catch. Another solution would be to load into a first, and then load into l at the end. It will screw up hl, but at that point it won't matter.

Or how about this?

Code:
That would probably be the best.