Author |
Message |
|
alexrudd pm me if you read this
Bandwidth Hog
Joined: 06 Oct 2004 Posts: 2335
|
Posted: 06 Jun 2005 03:58:31 pm Post subject: |
|
|
Currently, when you quote someone using the button, it adds a snapback button to the end and the QUOTE tag after that.
Quote: Yadayadayada
[post="12345"]<{POST_SNAPBACK}>[/post]
Code: [quote]Yadayadayada
[right][snapback]12345[/snapback][/right]
[/quote]
Could this be changed? It would be better if there were no return before the /snapback and the /quote tags. That way, there would not be two blank lines at the end of quotes and the snapback would be at the end of the quote. Perhaps a couple of spaces before the snapback, but that's it.
Quote: Yadayadayada [post="12345"]<{POST_SNAPBACK}>[/post]
EDIT: post #12345 leads to a fairly amusing discussion with sigma about TASM. Not intended to, but who cares?
Last edited by Guest on 06 Jun 2005 04:02:33 pm; edited 1 time in total |
|
Back to top |
|
|
DarkerLine ceci n'est pas une |
Super Elite (Last Title)
Joined: 04 Nov 2003 Posts: 8328
|
Posted: 06 Jun 2005 05:13:33 pm Post subject: |
|
|
You can always edit it manually. |
|
Back to top |
|
|
alexrudd pm me if you read this
Bandwidth Hog
Joined: 06 Oct 2004 Posts: 2335
|
Posted: 06 Jun 2005 05:22:19 pm Post subject: |
|
|
I usually do, but I notice many people don't and it would be nice to not have to bother. |
|
Back to top |
|
|
Arcane Wizard `semi-hippie`
Super Elite (Last Title)
Joined: 02 Jun 2003 Posts: 8993
|
Posted: 06 Jun 2005 06:04:24 pm Post subject: |
|
|
Can't find the code to change, I'll look around later. |
|
Back to top |
|
|
alexrudd pm me if you read this
Bandwidth Hog
Joined: 06 Oct 2004 Posts: 2335
|
Posted: 21 Jun 2005 04:09:29 pm Post subject: |
|
|
week_count+=2
Any progress? I know it's not a very important issue, but it is rather annoying. |
|
Back to top |
|
|
AlienCC Creative Receptacle!
Know-It-All
Joined: 24 May 2003 Posts: 1927
|
Posted: 03 Jul 2005 01:31:48 am Post subject: |
|
|
I can't find anywhere in the templates where this would be caused, or the stylesheet. Kind of irritating.
--AlienCC |
|
Back to top |
|
|
wrigley
Advanced Member
Joined: 19 May 2004 Posts: 399
|
Posted: 04 Jul 2005 04:39:37 pm Post subject: |
|
|
sometimes a mere space/newline will mess up the layout, check to make sure the tags in question are right beside eachother, no whitespace inbetween. |
|
Back to top |
|
|
Weregoose Authentic INTJ
Super Elite (Last Title)
Joined: 25 Nov 2004 Posts: 3976
|
Posted: 04 Jul 2005 04:50:34 pm Post subject: |
|
|
Maybe I should point out that it's only the [righṭ] tags that are causing the new line. |
|
Back to top |
|
|
alexrudd pm me if you read this
Bandwidth Hog
Joined: 06 Oct 2004 Posts: 2335
|
Posted: 03 Nov 2005 11:12:45 pm Post subject: |
|
|
Supergoose wrote: Maybe I should point out that it's only the [righṭ] tags that are causing the new line. [post="52944"]<{POST_SNAPBACK}>[/post] And they aren't needed anyway, if it's going to be on one line.
Yep, I just revived this because nothing's changed. |
|
Back to top |
|
|
Darth Android DragonOS Dev Team
Bandwidth Hog
Joined: 31 May 2003 Posts: 2104
|
Posted: 04 Nov 2005 07:48:45 pm Post subject: |
|
|
The changes are going to need to be made in one of the php files, its not in a template or a style sheet. I'll go dig up the BBCode parser and hunt down these bugs and hopeuflly get solutions for them.
EDIT:
Ok, ./sources/lib/post_parser.php
Line 223:
Code: //-----------------------------------------
// Do [CODE] tag
//-----------------------------------------
$txt = preg_replace( "#\[code\](.+?)\[/code\]#ies", "\$this->regex_code_tag( '\\1' )", $txt );
is where it expands the CODE tags.
Try moving that section of code after this part (line 307):
Code: // font size, colour and font style
// [font=courier]Text here[/font] [size=6]Text here[/size] [color=red]Text here[/color]
while ( preg_match( "#\[size=([^\]]+)\](.+?)\[/size\]#ies", $txt ) )
{
$txt = preg_replace( "#\[size=([^\]]+)\](.+?)\[/size\]#ies" , "\$this->regex_font_attr(array('s'=>'size','1'=>'\\1','2'=>'\\2'))", $txt );
}
while ( preg_match( "#\[font=([^\]]+)\](.*?)\[/font\]#ies", $txt ) )
{
$txt = preg_replace( "#\[font=([^\]]+)\](.*?)\[/font\]#ies" , "\$this->regex_font_attr(array('s'=>'font','1'=>'\\1','2'=>'\\2'))", $txt );
}
while( preg_match( "#\[color=([^\]]+)\](.+?)\[/color\]#ies", $txt ) )
{
$txt = preg_replace( "#\[color=([^\]]+)\](.+?)\[/color\]#ies" , "\$this->regex_font_attr(array('s'=>'col' ,'1'=>'\\1','2'=>'\\2'))", $txt );
}
That should cause it to parse the CODE tags after the QUOTE,COLOR,EMAIL,URL,etc.
On a side note, this code is from IPB 2.0.4, and UTI uses 2.0.3, so the line numbers may be off a bit if anything has changed in the file between the versions.
Last edited by Guest on 04 Nov 2005 08:33:02 pm; edited 1 time in total |
|
Back to top |
|
|
AlienCC Creative Receptacle!
Know-It-All
Joined: 24 May 2003 Posts: 1927
|
Posted: 04 Nov 2005 09:55:44 pm Post subject: |
|
|
UTI does not actually use 2.0.3, I manually patched all of the updates to 2.0.4, because of the modifications that are installed...therefore I did not manually update the version number of several files. I will try this fix later.
--AlienCC |
|
Back to top |
|
|
Darth Android DragonOS Dev Team
Bandwidth Hog
Joined: 31 May 2003 Posts: 2104
|
Posted: 05 Nov 2005 07:55:53 pm Post subject: |
|
|
Ok. I'll hunt down a fix for the RIGHT tags |
|
Back to top |
|
|
|