you could even plop that right in the output command and skip the string thing all together like this (right after you store it to Str1, you output it and that's the only time that string is used in the program, so you don<t need to store to a string at all)

Code:

I'm slightly confused about what this block does:

Code:


I don't think you use the value of R inside the loop, so you could move it to the end. Can it be changed to this?

Code:


You also have a second block similar to what was mentioned above:

Code:

This can be (you don't need the Delvar K in the other block either):

Code:


Also, you have many While and For( delay blocks (like For(A,0,200:End) that will be shorter, assuming Ans isn't tied up, as rand( delays (rand(25 for a 0.4 second delay).

Why are you using A=6 and 7 for "roll" and "hold" rather than sensible values like 1 and 0?

You can inline Lbl MW and Lbl LW.

Thanks, a ton for those optimizations, lirtosiast! I will change the While and For( blocks to rand( as you suggested, and I will also try remove some of the Goto's when I put it in sourcecoder so I can see the entirety of the program.
I have already combined MW and LW in to W.
And I don't know why I use 6,7 and 8. I just did.


Here's the current updated code WITH goto's and WITHOUT For( delay loops.

Code:


AND a screenshot.

I know the winner animation could use some optimization, but I like the way it looks:

Code:

Code:


And some small things...

Code:
could be
Code:

Code:
could be
Code:

Thanks for those optimizations also, but now, it seems like I will need a 16x16 die sprites. Botboy is hopefully making one that will work, but just in case, this is what I would end up doing.


Code:


The previous code for an 8x8 sprite is"

Code:

this is really just for aesthetics, but here:

you see the "1" side of the die? and how it looks like it has the most light on it? what i'm saying is that you should imagine there is a light overhead. the red circle is the primary area that is illuminated, making it white. now, you could still rotate the die, but for each rotation the side that is illuminated changes (leaving the side facing the light the one that is the most white).

it's hardly necessary but it might add a little. oh, and you like my drawing skills?

I don't think I'll do that, but thanks for the suggestion. And I really like them. Very powerful

Botboy was nice enough to supply me with some sprites, so I put them in to my spritesheet, and here we go!



Updated Code: Sprite displaying is crazy unoptimized again

Code:

So yeah, its pretty much all done now. If anyone wants to optimize feel free!

EDIT: Thanks to BotBoy's testing, he found that the AI was not triggering. It turned out that I was using the same variable for two different things. I just fixed that.

Further optimizations...

Code:

Should REALLY be changed to

Code:


Code:

could be

Code:


Code:

You can skip the new line after most Delvars to make some ugly but shorter code like this...

Code:


Code:

Here, you have the same condition twice (If P=1) and the first one already comes with a then and an End, so you could just put the second one in the first one like this...

Code:

Don't use variables you don't need.

Code:


This is all you need for the AI:

Code:

It holds at 15 on average when it's ahead, and 30 when it's behind, and always holds when it would win. (This isn't optimal, but it's close to what you have.) Change the numbers to weight it differently.

Ok then, thanks a ton to both of you.

Lirto, the AI code replaces this, yes?

Code:


Does it still store A to 7 and 6?

mr womp, I don't see how those If statements are the same thing.

Code:

If P=1
and
If P=2

EDIT: If you would like to do some testing, use these files:
https://usercontent.irccloud-cdn.com/file/jcFT9MCW/GOPSPRT.8xv
https://usercontent.irccloud-cdn.com/file/jAlfecMy/GAMOFPIG.8xp

They aren't the same thing
here is your original code, ignore the If P=2:Then:End condition, that's not what I'm playing with.

Code:

Notice the If P=1 condition is there twice, at the beginning and the end, and when it comes around for the first time, since there are more than one arguments in between the condition and the end, you put the Then and the End, so adding more arguments doesn't make a difference besides the fact that you lose one of the "If P=1"s, what I am recommending is that you take the 2nd If P=1 condition and put the arguments inside that condition in the first one, which is why in the new code, that you posted above, you only see one If P=1 condition, not 2 like in the original code.

Oh, I see. I got confused with the original and the code you made changes to.

Anyways, new code with the above (and PT_'s below) optimizations:

Code:


Download these files to test it out.
https://usercontent.irccloud-cdn.com/file/WC6DnPeY/GOPSPRT.8xv
https://usercontent.irccloud-cdn.com/file/onYKlj3f/GAMOFPIG.8xp

And go to http://cs.gettysburg.edu/projects/pig/piggame.html to learn to play.

It *could* be optimized, I think it would be slower but smaller:
Code:

to this:
Code:


EDIT:

Code:

can be this:
Code:

Thanks PT_, I think I'll add those in a few hours.

EDIT: lirtosiast, whatever you did to my code kind of broke it.

Its not displaying the dice to the correct coords, and I'm not going to pretend I know how you did it


Code:

Unicorn: Sorry about that, I meant

Code:


I may actually rewrite the whole program to be cleaner if I have the time.

* What do the variables T, E, and Y do? I thought Y was whether AI was being used; i.e. 0 for two-player mode, and 2 for one-player mode, but I'm confused by E. It doesn't look like you ever use T after initializing it to |E2.
* I think you can do without DelVar'ing all of the variables at the start; you initialize most of them anyway.

Here's the inlined replacement for Lbl W:

Code:

Ah, I guess that probably works

I think I confused myself with them. I think T was meant as a variable for a timing while loop, and E and Y were to make sure the "A.I." was activated, but I believe that E could be removed.

Ok, I'll do that, and thanks for the Lbl W replacement.

EDIT: Updated file: https://usercontent.irccloud-cdn.com/file/9NEq9g62/GAMOFPIG%20(2).8xp

bump.

Just a quick question: Do you guys think that there could be more optimizations that need to happen?? If not, I'm going to release it tomorrow.

Oh yeah, and lirtosiast, how can I make the A I hold more often? which value should I change?