As the title says, I have a If/Then/Menu/Else/Goto/End statement. I am wondering if there is a fix to this.

We'd have to see more code to be able to help you with that, to see what is going on, but using a Goto anytime a command needs an End statement to finish things off is a very bad thing.

The code for the part in question is:


Code:


The strings are the options (i use them more than once)

Edit: Is it possible to do:


Code:

Basically, get out of the habit of using Gotos inside of If/Then/End statements. I think there's a trick, might be a bit advanced, of using While loops instead.

The reason being, the OS keeps track of how many If statements it enters and lowers the count when it encounters an End. If the OS cannot close an If statement, the count will get higher with every goto. Eventually this count will slow down the calculator. Once you close the program the count is zero'd. Most huge slowdowns happen after a matter of hours, unless the program is just really badly coded or the infringing Goto(s) are called repeatedly.

Edit: Your example is do able. You do not need a Then statement for only one line of instruction.

I know, I was told that in an earlier thread, but do you think that me edit above would be a good alternative?

Sorry I do, keep in mind (and if I'm remembering correctly) that "else 2" is checking if Ans=2. But I could likely be wrong.

I am sorry for reviving an old thread, but I thought that this would be the first place to place it. I am creating a new program where I have a If/Then/Goto/End statement, but I have a Stop command before the End command, is this ok, are will it still cause a memory leak?

This will still cause the same issues.

So there is no way to stop this leak?
If not, can you tell me how to get around it?

Your best bet is to restructure your code to make it not require the GoTo. I can help with specifics if you show your code, but generally some sort of While or Repeat loop.

Here is my code right now:

Code:

Is there a suggested way that I could fix this?


Edit: Could I do this:

Code:

On thing I see right away is in quite a few places you have Goto _:Lbl _, the Goto _ is not needed and the code will work exactly the same without it.

I also recommend you replace all uses of "Stop" with Return as in most cases they will act the same but when working with shells such as Doors CS Return bahaves better and leaves the calculator in a cleaner state.

Though most modern shells like Doors CS will handle Stop fine it is still better practice to use Return.

One last thing, this doesn't appear to be all of your code as how is A being set right at the start and what is even the check for A=0 doing?

To address your specific concern, I would do something like this:

Code:


It's untested, so I may've screwed something up, but the basic idea is use a variable to be a flag, and do

Code:

And of course this is embeddable:

Code:

So the way that I like to approach the issue with that Menu command is as follows:


Code:


Once you run this, then you know that X holds the number of the label that you want. From there, you can use conditionals on X to check what to do, rather than jumping around in your program. I know that this might not be what you want, but it is a good practice that I like to use to prevent memory leaks.

So what does this do exactly?

With an extra variable that you change the value of when exiting loops, it's not too hard to get rid of Lbl/Goto entirely.

I generally prefer not using them in TI-BASIC, because it takes quite a while for the interpreter to reach a Lbl that is very far into the code (several seconds sometimes) compared to an If block that contains a nested loop.

So DJ, do you have any suggestions on what I could do to fix this problem, because I really want this program out soon

I know, I know, this is very old, but it still pertains to this topic. I think I may have a way around this, but I wanted to ask you guys first. Here is the code:

Code:

Why would you need the input thing? I was going to suggest a workaround but I'm not actually sure what you're trying to do here (I don't quite see how this code would help with avoiding memory leaks)
Unless you're trying to do the flag variable thing mentioned earlier?

It was an example. If I were to use If statements, it would have been:

Code:

and that creates a memory leak. I was wondering if using a while statement fixed it