high score AppVar not working - Cemetech | Forum

HacksAndSlash
Newbie (Posts: 16)

high score AppVar not working
27 Jan 2021 09:50:54 pm

The Code In question:

Code:




void gameOver()


{


      while(kb_Data[1] & kb_2nd)


         kb_Scan();


      uint8_t temp = 0;


      


      uint8_t* High = &temp;


      


      ti_var_t hs = ti_Open("XW3HS","r");


      


      ti_Read(High,4,1,hs);


      ti_Close(hs);


      if(*High < score)


      {


         hs = ti_Open("XW3HS","w");


         ti_Write((char)score,, sizeof(uint8_t),hs);


         ti_Close(hs);


         pgrm_CleanUp();


      } else


      {


         ti_Close(hs);


         pgrm_CleanUp();


      }


      char* appendValue1 = float2str(*High);


      char* appendValue2 = float2str(score);


      gfx_ScaledSprite_NoClip(background, 0, 0, 10, 10);





      


      gfx_PrintStringXY("YOUR SCORE:",(24+(16*11)),100);


      gfx_PrintStringXY(appendValue2,(24+(16*11)),110);


      


      gfx_PrintStringXY("PREV BEST:" ,24,100);


      gfx_PrintStringXY(appendValue1,24,110);


      


      gfx_PrintStringXY("PRESS 2ND TO CONTINUE",24,160);


      gfx_BlitBuffer();


      while(!(kb_Data[1] & kb_2nd))


         kb_Scan();


      while(kb_Data[1] & kb_2nd)


         kb_Scan();


}

it seems like the high score is either not reading or not writing corrfectly as the value does not seem to display correctly ie: it shows your current score instead of your high score

epsilon5
4
Super-Expert (Posts: 797)

27 Jan 2021 10:01:05 pm

Why are you casting score to a char, and why are you reading 4 bytes from hs when a uint8_t is 1 byte? I’d also like to know where score is defined, as I can’t seem to see it. Also, you’re using floattostr on a uint8_t, which could be causing some issues as well. Finally, there are two commas in the write.

HacksAndSlash
Newbie (Posts: 16)

27 Jan 2021 10:02:34 pm

epsilon5 wrote:

Why are you casting score to a char, and why are you reading 4 bytes from hs when a uint8_t is 1 byte? I’d also like to know where score is defined, as I can’t seem to see it. Also, you’re using floattostr on a uint8_t, which could be causing some issues as well. Finally, there are two commas in the write.

dang i didnt notice how shoddy my code was, thanks Smile

tr1p1ea
1
Cemetech Expert (Posts: 1742)

27 Jan 2021 10:04:20 pm

Just wondering what the range is for your score? Can it be a really big number?

HacksAndSlash
Newbie (Posts: 16)

27 Jan 2021 10:05:01 pm

tr1p1ea wrote:

Just wondering what the range is for your score? Can it be a really big number?

its usually a small-ish number but if your good it can get pretty big

HacksAndSlash
Newbie (Posts: 16)

27 Jan 2021 10:09:27 pm

Code:

void gameOver()


{


      while(kb_Data[1] & kb_2nd)


         kb_Scan();


      float temp = 0;


      


      float* High = &temp;


      


      ti_var_t hs = ti_Open("XW3HS","r");


      


      ti_Read(High,4,1,hs);


      ti_Close(hs);


      if(*High < score)


      {


         hs = ti_Open("XW3HS","w");


         ti_Write(&score,4,1,hs);


         ti_Close(hs);


         pgrm_CleanUp();


      } else


      {


         ti_Close(hs);


         pgrm_CleanUp();


      }


      char* appendValue1 = float2str(*High);


      char* appendValue2 = float2str(score);


      gfx_ScaledSprite_NoClip(background, 0, 0, 10, 10);





      


      gfx_PrintStringXY("YOUR SCORE:",(24+(16*11)),100);


      gfx_PrintStringXY(appendValue2,(24+(16*11)),110);


      


      gfx_PrintStringXY("PREV BEST:" ,24,100);


      gfx_PrintStringXY(appendValue1,24,110);


      


      gfx_PrintStringXY("PRESS 2ND TO CONTINUE",24,160);


      gfx_BlitBuffer();


      while(!(kb_Data[1] & kb_2nd))


         kb_Scan();


      while(kb_Data[1] & kb_2nd)


         kb_Scan();


}

hmmm i applied the fixes you reccomended and it seems to still not work

epsilon5
4
Super-Expert (Posts: 797)

27 Jan 2021 10:18:40 pm

HacksAndSlash wrote:

[code]
hmmm i applied the fixes you reccomended and it seems to still not work

What is your issue? I’m not sure you specified what it was.

commandblockguy
2
Minor Calculator Deity (Posts: 1128)

27 Jan 2021 10:45:11 pm

If you're only using integers/whole numbers for scores, I would recommend not using floats but an integer type like uint24_t. If you use integers, instead of doing

Code:

char* appendValue2 = float2str(score);


gfx_PrintStringXY(appendValue2,(24+(16*11)),110);

you can just do

Code:

gfx_SetTextXY(24+(16*11), 110);


gfx_PrintUInt(score, 1);

I'm guessing the issue here is in float2str - could we see the code for that, if you decide not to switch to integers? It's likely that the buffer that it's writing the string to is being overwritten the next time it's called, before the string is actually displayed.

You should also use sizeof to make sure that you don't overflow whatever you're reading into - e.g. ti_Write(&score,sizeof score,1,hs). Otherwise, you might read too many bytes and randomly change the value of some other variable.

I also don't see the need for a separate temp variable and High pointer - why not just use &temp in place of High and temp in place of *High?

Additionally, pgrm_CleanUp() is a compatibility define - it doesn't do anything anymore, so you can remove it with no ill effects.

HacksAndSlash
Newbie (Posts: 16)

28 Jan 2021 10:39:13 am

commandblockguy wrote:

If you're only using integers/whole numbers for scores, I would recommend not using floats but an integer type like uint24_t. If you use integers, instead of doing

Code:

char* appendValue2 = float2str(score);


gfx_PrintStringXY(appendValue2,(24+(16*11)),110);

you can just do

Code:

gfx_SetTextXY(24+(16*11), 110);


gfx_PrintUInt(score, 1);

I'm guessing the issue here is in float2str - could we see the code for that, if you decide not to switch to integers? It's likely that the buffer that it's writing the string to is being overwritten the next time it's called, before the string is actually displayed.

You should also use sizeof to make sure that you don't overflow whatever you're reading into - e.g. ti_Write(&score,sizeof score,1,hs). Otherwise, you might read too many bytes and randomly change the value of some other variable.

I also don't see the need for a separate temp variable and High pointer - why not just use &temp in place of High and temp in place of *High?

Additionally, pgrm_CleanUp() is a compatibility define - it doesn't do anything anymore, so you can remove it with no ill effects.

IT worked, Thank you Very Happy

epsilon5
4
Super-Expert (Posts: 797)

28 Jan 2021 06:42:26 pm

Why are you casting score to a char, and why are you reading 4 bytes from hs when a uint8_t is 1 byte? I’d also like to know where score is defined, as I can’t seem to see it. Also, you’re using floattostr on a uint8_t, which could be causing some issues as well. Finally, there are two commas in the write.